glib async methods return list for single result #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes altdesktop#108 The async method calls on the glib.ProxyInterface class lacked the ability to unpack a single result while the sync version did do that. This commit moves unpacking code to the async version so both will behave correctly.
|
While I feel the current test suite is sufficient to show there are not regressions from this change, I think it would be helpful to add tests that specifically check the asynchronous calls so that changes aren't made to just the synchronous calls that should apply to both. I attempted to write such tests, but I ran into a segfault with GLib that I am too tired/ignorant to know how to solve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108
The async method calls on the glib.ProxyInterface class lacked the
ability to unpack a single result while the sync version did do that.
This commit moves unpacking code to the async version so both will
behave correctly.